fix: type serverValidate decoded values

.changeset/quiet-lamps-warn.md

@@ -0,0 +1,6 @@
+---
+'@tanstack/react-form-nextjs': patch
+'@tanstack/react-form-remix': patch
+---
+
+Fix `createServerValidate` return types to reflect decoded `FormData` values instead of inferred form values.

packages/react-form-nextjs/src/createServerValidate.ts

@@ -99,12 +99,11 @@ export const createServerValidate =
       })
     }
 
-    const values = (info
-      ? decode(formData, info)
-      : decode(formData)) as never as TFormData
+    const values = info ? decode(formData, info) : decode(formData)
+    const validationValues = values as never as TFormData
 
     const onServerError = (await runValidator({
-      value: values,
+      value: validationValues,
       validationSource: 'form',
     })) as UnwrapFormAsyncValidateOrFn<TOnServer> | undefined
 
@@ -120,7 +119,7 @@ export const createServerValidate =
       errorMap: {
         onServer: onServerError,
       },
-      values,
+      values: validationValues,
       errors: onServerErrorVal ? [onServerErrorVal] : [],
     }
 

packages/react-form-nextjs/tests/createServerValidate.test-d.ts

@@ -0,0 +1,19 @@
+import { expectTypeOf, it } from 'vitest'
+import { createServerValidate, formOptions } from '../src'
+
+it('types serverValidate return values as decoded form data', () => {
+  const serverValidate = createServerValidate({
+    ...formOptions({
+      defaultValues: {
+        firstName: '',
+        age: 0,
+      },
+    }),
+    onServerValidate: async () => undefined,
+  })
+
+  type ServerValidateResult = Awaited<ReturnType<typeof serverValidate>>
+
+  expectTypeOf<ServerValidateResult>().toEqualTypeOf<Record<string, unknown>>()
+  expectTypeOf<ServerValidateResult['age']>().toEqualTypeOf<unknown>()
+})

packages/react-form-remix/src/createServerValidate.ts

@@ -99,12 +99,11 @@ export const createServerValidate =
       })
     }
 
-    const values = (info
-      ? decode(formData, info)
-      : decode(formData)) as never as TFormData
+    const values = info ? decode(formData, info) : decode(formData)
+    const validationValues = values as never as TFormData
 
     const onServerError = (await runValidator({
-      value: values,
+      value: validationValues,
       validationSource: 'form',
     })) as UnwrapFormAsyncValidateOrFn<TOnServer> | undefined
 
@@ -120,7 +119,7 @@ export const createServerValidate =
       errorMap: {
         onServer: onServerError,
       },
-      values,
+      values: validationValues,
       errors: onServerErrorVal ? [onServerErrorVal] : [],
     }
 

packages/react-form-remix/tests/createServerValidate.test-d.ts

@@ -0,0 +1,19 @@
+import { expectTypeOf, it } from 'vitest'
+import { createServerValidate, formOptions } from '../src'
+
+it('types serverValidate return values as decoded form data', () => {
+  const serverValidate = createServerValidate({
+    ...formOptions({
+      defaultValues: {
+        firstName: '',
+        age: 0,
+      },
+    }),
+    onServerValidate: async () => undefined,
+  })
+
+  type ServerValidateResult = Awaited<ReturnType<typeof serverValidate>>
+
+  expectTypeOf<ServerValidateResult>().toEqualTypeOf<Record<string, unknown>>()
+  expectTypeOf<ServerValidateResult['age']>().toEqualTypeOf<unknown>()
+})