`infiniteQueryOptions` can't be used with both `useInfiniteQuery` and `useSuspenseInfiniteQuery`

[alisamonstr]

Describe the bug

When upgrading from 5.59.9 to 5.59.14 the types from basic infiniteQueryOptions changed so they don't work with both useInfiniteQuery and useSuspenseInfiniteQuery when you set

 "compilerOptions": {
    "strict": true,
    "exactOptionalPropertyTypes": true
  }

Your minimal, reproducible example

https://stackblitz.com/edit/vitejs-vite-xfkpkc?file=src%2FApp.tsx

Steps to reproduce

1. Go to App.tsx
2. Observe Type error on line 41 (infiniteQueryResult)
3. Downgrade to "@tanstack/react-query": "5.59.9"
4. Go back to App.tsx and observe that the Type error is gone

Expected behavior

Not having a Type error

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

• Typescript "5.6.2"

Tanstack Query adapter

react-query

TanStack Query version

5.59.14

TypeScript version

5.6.2

Additional context

No response

[TkDodo]

Do you think adding | undefined here would fix it?

query/packages/react-query/src/infiniteQueryOptions.ts

Lines 50 to 62 in a085c92

	> & {
	queryFn?: Exclude<
	UseInfiniteQueryOptions<
	TQueryFnData,
	TError,
	TData,
	TQueryFnData,
	TQueryKey,
	TPageParam
	>['queryFn'],
	SkipToken
	>
	}

[alvarlagerlof]

Do you think adding | undefined here would fix it?

(same team) It doesn't fix it because infiniteQueryOptions still matches UnusedSkipTokenInfiniteOptions, which isn't supported by any of the useInifiniteQuery overloads. Previously, our infiniteQueryOptions used the UndefinedInitialDataInfiniteOptions type.

[TkDodo]

@gwansikk I think this traces back to your PR:

• refactor: throw type error when skipToken is present in suspense query #8082

could you please have a look?

[gwansikk]

I have reviewed the example project you provided, but I couldn’t reproduce the bug you mentioned. Could you please provide more detailed information about the issue?

[alvarlagerlof]

I have reviewed the example project you provided, but I couldn’t reproduce the bug you mentioned. Could you please provide more detailed information about the issue?

Try adding "exactOptionalPropertyTypes": true to the tsconfig.app.json file. It seems like it it wasn't always enough to just have it in the tsconfig.json.

You should see an error like this:

[gwansikk]

Try adding "exactOptionalPropertyTypes": true to the tsconfig.app.json file. It seems like it it wasn't always enough to just have it in the tsconfig.json.

@alvarlagerlof Thank you! I will look into finding an appropriate solution as soon as possible.

[alvarlagerlof]

Do you think adding | undefined here would fix it?

query/packages/react-query/src/infiniteQueryOptions.ts

Lines 50 to 62 in a085c92

& {
queryFn?: Exclude<
UseInfiniteQueryOptions<
TQueryFnData,
TError,
TData,
TQueryFnData,
TQueryKey,
TPageParam
>['queryFn'],
SkipToken

}

I realize now that I misinterpreted this and didn't add the | undefined at the right place in my local edit when testing. Anyways the fix worked. Thanks everyone!