fix(vue-query-devtools): update client when prop changes - #11413
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe Vue devtools components now update their client through ChangesVue devtools client synchronization
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Vue devtools now follows client-prop changes without remounting, including restoring the context client when an override is removed. The covered behavior is ready to merge with no identified release risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎯 Changes
In
@tanstack/vue-query-devtools, bothdevtools.vue(floating) anddevtoolsPanel.vue(embedded) capturedprops.clientonce upon instantiation. While watchers updated other options such as position, theme, and error types,devtools.setClient(...)was never called when theclientprop changed.devtools.setClient(props.client || client)withinwatchEffectin both components.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit
Bug Fixes
Tests