Skip to content

fix(start-plugin-core): guard hotUpdate against missing this.environment #8061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TIMTOMTOP wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −0
Open

fix(start-plugin-core): guard hotUpdate against missing this.environment #8061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61d61df
fix(start-plugin-core): guard hotUpdate against missing this.environment
TIMTOMTOP Aug 13, 2026
d94bd93
fix(start-plugin-core): use braced block for hotUpdate guard
TIMTOMTOP Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/start-compiler-hot-update-bundled-dev.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/start-plugin-core': patch
---

Guard the start compiler plugin's `hotUpdate` hook against a missing `this.environment`, which crashed every hot update (and left the dev server serving stale output) when Vite's `experimental.bundledDev` passes the hook to Rolldown's dev engine.
6 changes: 6 additions & 0 deletions packages/start-plugin-core/src/vite/start-compiler-plugin/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,12 @@ export function startCompilerPlugin(
},

hotUpdate(ctx) {
// Rolldown's dev engine (`experimental.bundledDev`) invokes this hook
// without an environment; invalidation then happens via `watchChange`.
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
if (!this.environment) {
return
}
const compiler = compilers.get(this.environment.name)
const idsToInvalidate = new Set<string>()
const transitiveCompilerImportersToInvalidate = new Set<string>()
Expand Down