fix(table-core): auto-remove empty arrHas filter values like the other array filters by greymoth-jp · Pull Request #6356 · TanStack/table

greymoth-jp · 2026-06-28T21:58:18Z

arrHas is the only one of the four array-valued filter functions that doesn't define an autoRemove handler. Its siblings arrIncludes, arrIncludesAll and arrIncludesSome all use the same one:

{ autoRemove: (val: any) => testFalsy(val) || !val?.length }

Because arrHas has none, shouldAutoRemoveFilter falls back to the built-in rules, which only drop a filter when the value is undefined or an empty string. An empty array ([]) gets through, so the filter stays active and [].some(...) returns false for every row. The column then hides everything instead of behaving like "no filter set". The other three array filters auto-remove an empty array and show all rows, and #6332 recently made the range filters (between / betweenInclusive) do the same for empty pairs.

This gives arrHas the same autoRemove as the rest of the array-filter family: empty or blank values are removed, a non-empty array keeps the filter active.

I added a regression test under a new Array Filters block, mirroring the existing between / betweenInclusive autoRemove tests.

Summary by CodeRabbit

Bug Fixes
- Improved array-based filtering so empty or unset filter values (such as undefined, null, empty strings, and empty arrays) are automatically ignored.
- Filtering behavior is now more consistent by automatically removing empty “arr has” filter selections to avoid unintended active filters.

…r array filters arrHas was the only array-valued filter function without an autoRemove handler, so an empty array filter value was never removed and hid every row.

coderabbitai · 2026-06-28T21:58:32Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 367169f8-c1a1-4cbc-bb63-a53243d40ab8

📥 Commits

Reviewing files that changed from the base of the PR and between be97b81 and 426274a.

📒 Files selected for processing (11)

examples/angular/with-tanstack-form/src/app/app.html
examples/angular/with-tanstack-form/src/app/header-components.ts
examples/angular/with-tanstack-form/src/app/row-submit-table-row.ts
examples/angular/with-tanstack-form/src/app/table-components.ts
examples/preact/with-tanstack-form/src/form.tsx
examples/react/with-tanstack-form/src/form.tsx
examples/solid/with-tanstack-form/src/App.tsx
examples/solid/with-tanstack-form/src/index.tsx
examples/solid/with-tanstack-form/src/table.tsx
examples/vue/with-tanstack-form/src/App.vue
examples/vue/with-tanstack-form/src/table.ts

✅ Files skipped from review due to trivial changes (11)

examples/solid/with-tanstack-form/src/index.tsx
examples/solid/with-tanstack-form/src/App.tsx
examples/angular/with-tanstack-form/src/app/row-submit-table-row.ts
examples/angular/with-tanstack-form/src/app/app.html
examples/angular/with-tanstack-form/src/app/table-components.ts
examples/angular/with-tanstack-form/src/app/header-components.ts
examples/solid/with-tanstack-form/src/table.tsx
examples/preact/with-tanstack-form/src/form.tsx
examples/vue/with-tanstack-form/src/table.ts
examples/vue/with-tanstack-form/src/App.vue
examples/react/with-tanstack-form/src/form.tsx

📝 Walkthrough

Walkthrough

filterFn_arrHas now includes autoRemove behavior for falsy or empty filter values, with tests added for the new cases. Several example files were reformatted without changing bindings, props, or logic.

Changes

arrHas autoRemove

Layer / File(s)	Summary
autoRemove implementation and tests `packages/table-core/src/fns/filterFns.ts`, `packages/table-core/tests/unit/fns/filterFns.test.ts`	`filterFn_arrHas` is wrapped with `Object.assign` to add `autoRemove`, and tests cover undefined, null, empty string, empty array, and non-empty array inputs.

Example formatting updates

Layer / File(s)	Summary
Angular form markup and controls `examples/angular/with-tanstack-form/src/app/app.html`, `examples/angular/with-tanstack-form/src/app/header-components.ts`, `examples/angular/with-tanstack-form/src/app/row-submit-table-row.ts`, `examples/angular/with-tanstack-form/src/app/table-components.ts`	Angular status text, button markup, column filter computed values, save-button disabled binding, page-size handler, and row-count template formatting are updated without changing behavior.
Solid form rendering `examples/solid/with-tanstack-form/src/App.tsx`, `examples/solid/with-tanstack-form/src/index.tsx`, `examples/solid/with-tanstack-form/src/table.tsx`	Solid row rendering, devtools JSX, and numeric filter input value expressions are reformatted while keeping the same props and fallback values.
React, Preact, and Vue formatting `examples/preact/with-tanstack-form/src/form.tsx`, `examples/react/with-tanstack-form/src/form.tsx`, `examples/vue/with-tanstack-form/src/App.vue`, `examples/vue/with-tanstack-form/src/table.ts`	React and Preact imports, Vue import/type declarations, Vue sort-title signature formatting, and Vue numeric filter tuple expressions are reformatted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

KevinVandy

Poem

🐇 I hop through filters, neat and fine,
Empty arrays fade on cue in line.
In example lands, the spacing glows,
While bunny-tested logic still clearly shows.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the core change: adding auto-remove behavior for empty arrHas filter values.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-06-28T23:11:49Z

View your CI Pipeline Execution ↗ for commit be97b81

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:sherif,t...`	✅ Succeeded	4m 4s	View ↗
`nx run-many --targets=build --exclude=examples/**`	✅ Succeeded	13s	View ↗

☁️ Nx Cloud last updated this comment at 2026-06-28 23:18:52 UTC

pkg-pr-new · 2026-06-28T23:16:01Z

More templates

@tanstack/angular-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table@6356

@tanstack/angular-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table-devtools@6356

@tanstack/lit-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/lit-table@6356

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/TanStack/table/@tanstack/match-sorter-utils@6356

@tanstack/preact-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table@6356

@tanstack/preact-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table-devtools@6356

@tanstack/react-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table@6356

@tanstack/react-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table-devtools@6356

@tanstack/solid-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table@6356

@tanstack/solid-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table-devtools@6356

@tanstack/svelte-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/svelte-table@6356

@tanstack/table-core

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-core@6356

@tanstack/table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-devtools@6356

@tanstack/vue-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table@6356

@tanstack/vue-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table-devtools@6356

commit: 426274a

fix(table-core): auto-remove empty arrHas filter values like the othe…

be97b81

…r array filters arrHas was the only array-valued filter function without an autoRemove handler, so an empty array filter value was never removed and hid every row.

ci: apply automated fixes

426274a

KevinVandy merged commit 82978d7 into TanStack:beta Jun 28, 2026
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(table-core): auto-remove empty arrHas filter values like the other array filters#6356

fix(table-core): auto-remove empty arrHas filter values like the other array filters#6356
KevinVandy merged 2 commits into
TanStack:betafrom
greymoth-jp:fix/arrhas-autoremove

greymoth-jp commented Jun 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 28, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Jun 28, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jun 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

greymoth-jp commented Jun 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Jun 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greymoth-jp commented Jun 28, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 28, 2026 •

edited

Loading

nx-cloud Bot commented Jun 28, 2026 •

edited

Loading