refactor(table-core): remove SyntheticEvent persist() calls#6448
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughHandlers for row selection, row expansion, sorting, and column resizing no longer call optional ChangesSynthetic event persistence removal
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 3e74221
☁️ Nx Cloud last updated this comment at |
KevinVandy
approved these changes
Jul 24, 2026
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Removes the
(e as any).persist?.()calls from the sorting, expanding, resizing, and selection event handlers, plus the JSDoc / generated reference docs that described them.persist()was a workaround for React's SyntheticEvent pooling, which was removed in React 17 (the method has been a deprecated no-op since then). v9 requiresreact >= 18, so these calls can't do anything anymore. Dropping them also removes 4as anycasts from table-core.References:
e.persist()is still available on the React event object, but now it doesn't do anything."persist(): Not used with React DOM."✅ Checklist
pnpm test:pr.Assisted-by: Claude Code:claude-fable-5