Add getLeafHeaders() method to skip group headers - #6579
Conversation
`collectLeafHeaders` now excludes parent/group headers from results `table_getLeafHeaders` returns only real leaf headers instead of placeholders Fix the issue: Leaf rows are not calculated correctly TanStack#6573
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe header utilities now return only real leaf headers in left-to-right order. Documentation describes the behavior, and unit tests cover nested, group, intermediate, and placeholder headers. ChangesLeaf header collection
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change makes leaf-header collection return only real leaf headers, with matching tests and documentation updates. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
getLeafHeaders() method to skip group headersgetLeafHeaders() method to skip group headers #6573
getLeafHeaders() method to skip group headers #6573getLeafHeaders() method to skip group headers
🎯 Changes:
Fixes: #6573
collectLeafHeadersnow excludes parent/group headers from results.table_getLeafHeadersreturns only real leaf headers instead of placeholdersSummary by CodeRabbit
Bug Fixes
Documentation