fix: support shared package manager commands in docs exports - #1225
Draft
LadyBluenotes wants to merge 1 commit into
Draft
fix: support shared package manager commands in docs exports#1225LadyBluenotes wants to merge 1 commit into
LadyBluenotes wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | ac6df39 | Commit Preview URL Branch Preview URL |
Sep 06 2026, 02:18 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the Markdown parser's package-manager transform for Markdown export and framework discovery, so they consume the same shared/framework command groups as the native tabs. Apply package-manager filtering on the frameworkless
.mdroute too.An unprefixed block can now supply three separate commands without repeating them for every framework:
The existing native package-manager component already supports the parser's empty-key fallback group, including synchronized and persisted package-manager selection. No component changes are needed. Shared lines do not advertise a framework variant, and mixed shared/framework lines retain source order.
docs-info.mddocuments this syntax and fenced literal arguments.Dependency
Draft pending TanStack/markdown#12 and a release containing that change. Before this PR is ready, update
@tanstack/markdownand its lockfile entry to that release.This PR retains the existing dependency and lockfile (currently locked to
0.0.11). A clean install with that lockfile cannot pass the new shared-command regression assertions yet. No local tarball path or unpublished version is committed.Verification
Tested against a locally packed build of TanStack/markdown#12 in an isolated checkout; temporary dependency edits were removed before committing.
pnpm testpassed, including typechecks and lint: 478 tests passed, one existing environment-gated skip.pnpm buildpassed.git diff --checkpassed for all four changed files.Regression assertions cover shared-only and mixed blocks, unknown/no framework selection, unchanged output without a package-manager selection, preserved markers, and literal command arguments.