Skip to content

fix: support shared package manager commands in docs exports - #1225

Draft
LadyBluenotes wants to merge 1 commit into
mainfrom
fix/frameworkless-package-manager-tabs
Draft

fix: support shared package manager commands in docs exports#1225
LadyBluenotes wants to merge 1 commit into
mainfrom
fix/frameworkless-package-manager-tabs

Conversation

@LadyBluenotes

Copy link
Copy Markdown
Member

Description

Use the Markdown parser's package-manager transform for Markdown export and framework discovery, so they consume the same shared/framework command groups as the native tabs. Apply package-manager filtering on the frameworkless .md route too.

An unprefixed block can now supply three separate commands without repeating them for every framework:

<!-- ::start:tabs variant="package-manager" mode="local-install" -->

@tanstack/intent@latest list
@tanstack/intent@latest validate
@tanstack/intent@latest review

<!-- ::end:tabs -->

The existing native package-manager component already supports the parser's empty-key fallback group, including synchronized and persisted package-manager selection. No component changes are needed. Shared lines do not advertise a framework variant, and mixed shared/framework lines retain source order. docs-info.md documents this syntax and fenced literal arguments.

Dependency

Draft pending TanStack/markdown#12 and a release containing that change. Before this PR is ready, update @tanstack/markdown and its lockfile entry to that release.

This PR retains the existing dependency and lockfile (currently locked to 0.0.11). A clean install with that lockfile cannot pass the new shared-command regression assertions yet. No local tarball path or unpublished version is committed.

Verification

Tested against a locally packed build of TanStack/markdown#12 in an isolated checkout; temporary dependency edits were removed before committing.

  • pnpm test passed, including typechecks and lint: 478 tests passed, one existing environment-gated skip.
  • pnpm build passed.
  • Formatting and git diff --check passed for all four changed files.
  • A browser probe using the native package-manager tabs verified four package managers across eight framework/no-framework routes, three command lines in each of two synchronized blocks, and selection persistence after reload, with no page errors.

Regression assertions cover shared-only and mixed blocks, unknown/no framework selection, unchanged output without a package-manager selection, preserved markers, and literal command arguments.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com ac6df39 Commit Preview URL

Branch Preview URL
Sep 06 2026, 02:18 AM

@tannerlinsley tannerlinsley added the source-audit Tracked by the automated source audit label Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

source-audit Tracked by the automated source audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants