fix(router): Wrap root error/404 components in HTML shell - #1226
Open
sentry[bot] wants to merge 1 commit into
Open
fix(router): Wrap root error/404 components in HTML shell#1226sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 6a9d462 | Commit Preview URL Branch Preview URL |
Sep 06 2026, 11:08 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
HierarchyRequestErrorthat occurred when the root route'serrorComponent(DefaultCatchBoundary) ornotFoundComponent(NotFound) were rendered. Previously, these components were rendered directly without an<html><body>wrapper, causing React to attempt to append a<div>directly to thedocument, which already has an<html>element.The
ShellComponentcould not be used directly as a wrapper due to its internal dependencies on router hooks, which might not be stable during error or 404 rendering.Changes Made:
RootDocumentShell: A minimal component providing the necessary<html><head><body>structure, including<HeadContent />and<Scripts />, without relying on router-specific contexts.RootErrorBoundaryandRootNotFound: These components wrapDefaultCatchBoundaryandNotFoundrespectively, rendering them inside theRootDocumentShell.src/routes/__root.tsx: TheerrorComponentandnotFoundComponentproperties of the root route now point toRootErrorBoundaryandRootNotFound.This ensures that even when an error or 404 occurs at the root level, a complete and valid HTML document structure is always rendered, preventing the
HierarchyRequestError.Fixes TANSTACK-COM-4DB
This PR was automatically generated by Sentry. You can adjust this setting at any time.