Reject incomplete sitemap generation and recover after source failures - #1267
Reject incomplete sitemap generation and recover after source failures#1267tannerlinsley wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 2808922 | Commit Preview URL Branch Preview URL |
Sep 12 2026, 12:42 AM |
A failed or empty documentation manifest could produce a 200 sitemap with an entire library missing. Sitemap generation now fails explicitly with 503, no-store headers, and Retry-After instead of publishing that reduced result. Logs identify the failed library or catalog and record successful generation after recovery.
GitHub directory fallback now visits all depths and rejects a listed child directory that disappears. Cached trees with unvisited directories are rejected, and the manifest cache key changes so old depth-limited manifests are rebuilt. Local directory reads use the same complete traversal. Local-only one-millisecond file/tree caching was removed after the HTTP recovery test demonstrated that it kept serving an empty tree after the fixture was restored. Production GitHub cache behavior remains in place.
Stacked on #1264, which supplies the freshness metadata already used by sitemap entries.
Validation:
pnpm testpassed: 525 tests passed, 4 opt-in skips, TypeScript and lint clean. The commit hook repeated the final checks successfully.sitemap-testing.mdandscripts/prepare-sitemap-test.tsmake the HTTP check reproducible.