Skip to content

fix: upgrade Redact to 0.1.2 - #1271

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/upgrade-redact-0-1-2
Sep 12, 2026
Merged

fix: upgrade Redact to 0.1.2#1271
tannerlinsley merged 1 commit into
mainfrom
taren/upgrade-redact-0-1-2

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Sep 12, 2026

Copy link
Copy Markdown
Member

Upgrade @tanstack/redact from 0.1.0 to 0.1.2 to fix dialogs staying mounted after their closing animation and stale route matches during pending parent updates.

Fixes #1269. Library fixes: TanStack/redact#33

Only the Redact dependency and lockfile entry change. The published package and npm integrity are verified.

Validation:

  • pnpm test: types, lint, and 515 unit tests pass, with three existing skips.
  • The production Vite build and isolated browser smoke pass with the installed npm package, including hydration, navigation/history, blog filters, Radix menus, theme changes, and mobile navigation.
  • Production-bundle integration with Router 1.170.35 and Radix Dialog 1.1.15 passes 15 navigations and five animated dialog cycles for both React and Redact, with no browser errors.
  • The live deployment still reproduces the stuck dialog before this upgrade. Follow-up verification covers Query, Router, and Start docs navigation plus library, cart, and search overlays.

Summary by CodeRabbit

  • Chores
    • Updated the development tooling package to version 0.1.2.

@tannerlinsley
tannerlinsley requested a review from a team September 12, 2026 15:50
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 12, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 175dfaf Commit Preview URL

Branch Preview URL
Sep 12 2026, 03:52 PM

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ffc73914-11a1-41ca-8c2d-2534958e85e9

📥 Commits

Reviewing files that changed from the base of the PR and between 81f17c6 and 175dfaf.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates the @tanstack/redact development dependency in package.json from ^0.1.0 to ^0.1.2.

Changes

Redact dependency update

Layer / File(s) Summary
Update redact development dependency
package.json
The @tanstack/redact development dependency constraint changes from ^0.1.0 to ^0.1.2.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: ladybluenotes

Merge Risk: ⚪ Minimal · up to 175df

This dependency-only update is ready to merge; the requested dialog and navigation fixes are covered by the upgraded package and validation passed.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: upgrading @tanstack/redact to version 0.1.2.
Linked Issues check ✅ Passed Issue #1269 requires dialogs to fully close so they no longer remain interactive or block page interactions. The pull request upgrades @tanstack/redact from ^0.1.0 to ^0.1.2, which the summary i…
Out of Scope Changes check ✅ Passed The reviewed changes update only the @tanstack/redact dependency and its lockfile entry. The dependency update directly targets issue #1269 and the related stale route behavior. No unrelated source …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch taren/upgrade-redact-0-1-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tannerlinsley
tannerlinsley merged commit 5bbef8d into main Sep 12, 2026
7 checks passed
@tannerlinsley
tannerlinsley deleted the taren/upgrade-redact-0-1-2 branch September 12, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dialogs are never fully closed

1 participant