Conversation
Safari discards a scrollTop write made while an inner scroller is rubber-banding past its top edge and animates back to 0. In a chat that loads history when the user reaches the top, a prepend landing during the bounce loses its anchor write and the reader ends up a whole prepend away from their row (TanStack#1287). Suppressing the bounce with `overscroll-behavior: none` closes that window; verified in Safari 18.4. Adds it to the chat guide's production checklist next to `overflow-anchor: none`, which the react chat example already set but the guide did not mention, and applies it to the example's scroller. Refs TanStack#1287 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe chat checklist now requires disabling scroll anchoring and overscroll bounce. The React chat example applies ChangesChat scroll controls
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Merge Risk: ⚪ Minimal · up to The chat scroll guidance and example include the required scroll controls, with no established merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 61f7f86
☁️ Nx Cloud last updated this comment at |
Safari discards a
scrollTopwrite made while an inner scroller is rubber-banding past its top edge and animates back to 0. In a chat that loads history when the user reaches the top, a prepend landing during the bounce loses its anchor write and the reader ends up a whole prepend away from their row (#1287).overscroll-behavior: nonesuppresses the bounce and closes that window. Verified in Safari 18.4 with a trackpad: the rubber band is gone and prepends anchor as expected.🎯 Changes
overflow-anchor: none(the react chat example already set it, the guide did not mention it) andoverscroll-behavior: nonewith the Safari rationale.overscroll-behavior: noneon.Messages.Refs #1287
✅ Checklist
pnpm run test:pr.🚀 Release Impact
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation