Create sol5.py#425
Merged
Merged
Conversation
added a solve for the problem
Contributor
|
@alpylmz follow PEP8 |
ctrlaltvikas
suggested changes
Oct 12, 2018
ctrlaltvikas
left a comment
ctrlaltvikas
left a comment
Contributor
There was a problem hiding this comment.
Please change the PR name to a easily understandable title.
Member
|
@alpylmz Line 3 is a Python syntax error. Could you please fix that and resubmit? |
This was referenced Jun 1, 2019
Closed
|
Shouldn't this solution be in project euler folder with all other solutions? |
Member
|
Does this solution actually solve the problem? |
|
No it doesn't. With the syntax error you mentioned fixed it still creates infinite loop and it doesn't follow pep8. Now I see. |
Member
|
And will it solve the problem even if the syntax error is fixed? while a=<1000: -> while a<=1000: |
|
No it won't. Logic has to be changed. |
Member
|
Should we delete this file? |
|
Yes. |
Contributor
|
Yes, delete this file. File path, logic and standards - all incorrect. |
cclauss
added a commit
to cclauss/Python
that referenced
this pull request
Jun 8, 2019
As discussed at TheAlgorithms#425 (comment) this file contains syntax, logic, style, and naming errors that are causing our LGTM build process to fail. @StephenGemin, @shuklalok, @vikaskyadav, @poyea, @mrWiecek your reviews please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a solve for the problem