Move differential crate from . to directory - #575
Merged
Conversation
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
force-pushed
the
separate_dd
branch
from
February 20, 2025 07:50
458b96e to
b75307c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the differential crate from the repository root to the
differential-dataflowdirectory.At the same time, convert the differential dependency to a workspace dependency instead of referring to it by a relative path.
This change isn't strictly necessary, but I'd like to get us into a position where we don't have any code specific to columnation (other than implementations that cannot live anywhere else) in differential and move implementations shared between examples to a separate crate that we don't publish. We could do the same now, but I feel it would add complexity, and this change gets the repository into a state where it'd be a cleaner change in the future.