interactive: remove superseded code (col.rs, infer_shape) - #813
Merged
frankmcsherry merged 4 commits intoJul 31, 2026
Merged
Conversation
collect_present was the one non-delta-proportional path left: an O(trace) rescan (plus per-chunk key re-hashing) every retire, ~50% of an incremental round's profile. It now decides per retire, when the sizes are known: a narrow changed set over seekable keys (single-leaf: ids ARE key values, so the ascending changed set converts to a needle column) gallops each chunk once per changed key with find_ranges — no hashing at all; broad churn keeps the scan, whose flat membership test beats marginal seeking (a find_ranges probe is a structurally-dispatched binary search; SEEK_ADVANTAGE=16 measured as a load regression before widening to 64). Hashed ids of structural keys cannot be inverted into needles and always scan. Steady-state (1000 rounds x batch 100, 100k/200k): reach 4.51s -> 2.10s — past the vec backend's 2.51s (1.8x -> 0.84x); scc 794 -> 597ms/round, the residual being retires whose label cascades genuinely broaden the changed set — the windowed-presentation seam's territory, not a threshold's. Load-shaped scc unchanged (3.60s). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
infer_shape (single-sample) had no callers but its own recursion — container.rs
imports only infer_shape_cols — and its doc's justification ('stays for the
single-sample callers that never carry variants') described callers that no
longer exist. It also carried a panic for the Variant case that infer_shape_cols
exists precisely to handle. Gate green, debug and release.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…parked col.rs was commented out of backend/mod.rs pending 'a Columnar/columnar-storage story for Value'. That story arrived as corgi. The module cannot be revived as written: its Row(pub Vec<i64>) and columnar::Vecs<Vec<i64>, Strides> are the FLAT i64 row model DDIR abandoned for structured ir::Value (Int/Tuple/Variant/List), so reviving it would mean rewriting it — which is what the corgi backend is. 259 lines plus a .disabled example, neither compiled. git history keeps them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent removals from an architecture review, in separate commits so either can be dropped. Gate green (12 programs, debug and release); neither touches compiled behaviour.
f5bf60ed—infer_shape(11 lines). Uncontroversial: it had no callers but its own recursion (container.rsimports onlyinfer_shape_cols), its doc justified itself by "single-sample callers" that no longer exist, and it carried apanic!for theVariantcase thatinfer_shape_colsexists precisely to handle. One shape-inference function instead of two.77582558—backend/col.rs+ddir_col.rs.disabled(259 lines, uncompiled). The judgment call, so it is its own commit. It was commented out ofbackend/mod.rspending "aColumnar/columnar-storage story forValue" — that story arrived as corgi. The module cannot be revived as written: itsRow(pub Vec<i64>)andcolumnar::Vecs<Vec<i64>, Strides>are the flat i64 row model DDIR abandoned for structuredir::Value, so reviving it would mean rewriting it, and the rewrite is the corgi backend. Drop this commit if you would rather keep it parked; git history holds it either way.🤖 Generated with Claude Code