Implementing support for more accurate github embed colors

[Suleman70]

This is for issue #1074 - Make the github embed have more accurate colors

What I have Done:

1. For issues that are "completed", they become purple as it is assumed their PR's have been merged.

Before:

After:

2. For issues that are "not planned", they become gray.

Before:

After:

3.For PR's that are "drafts", they become gray but lighter than "not planned" issues, so that it could be differentiated.

Before:

After:

4. For PR's that are "Merged", they become purple.

Before:

After:

[Zabuzard]

pictures for the PR description please. before and after. thanks

[SquidXTV]

Is there no better purple color for completed? It seems too bright for me and doesn't match the color that GitHub uses.

Reference image:

[Taz03]

while we're at it, also change other colors to be github themed

[SquidXTV]

while we're at it, also change other colors to be github themed

What do you mean exactly? The other ones are GitHub themed already, no?

[Suleman70]

I am not sure whether it is possible with GHIssue to determine whether an PR has been merged or not.

For example this is an PR that has been closed and merged:

Its "closed" but has no state reason, so i am not sure how to detect whether it was merged

The classes: GHIssue and its inner static class: PullRequest dont have any relevant fields to determine this.

Does anyone have suggestions?

[Suleman70]

while we're at it, also change other colors to be github themed

Is there any particular color that i should change? The green could be darker, but the red and gray looks good.

[SquidXTV]

I am not sure whether it is possible with GHIssue to determine whether an PR has been merged or not.

For example this is an PR that has been closed and merged: Its "closed" but has no state reason, so i am not sure how to detect whether it was merged

The fields in GHIssue and its inner static class: PullRequest dont have any relevant fields to determine this.

Does anyone have suggestions?

I might be out of context but we use kohsuke github api for java right?
I found this GHPullRequest#isMerged method:
https://github-api.kohsuke.org/apidocs/org/kohsuke/github/GHPullRequest.html#isMerged()

[Suleman70]

I am not sure whether it is possible with GHIssue to determine whether an PR has been merged or not.
For example this is an PR that has been closed and merged: Its "closed" but has no state reason, so i am not sure how to detect whether it was merged
The fields in GHIssue and its inner static class: PullRequest dont have any relevant fields to determine this.
Does anyone have suggestions?

I might be out of context but we use kohsuke github api for java right? I found this GHPullRequest#isMerged method: https://github-api.kohsuke.org/apidocs/org/kohsuke/github/GHPullRequest.html#isMerged()

Thank you so much, I will look into this.

[Suleman70]

It should now work for pull requests.

[SquidXTV]

It should now work for pull requests.

"it should"? did you test it?

[Suleman70]

It should now work for pull requests.

"it should"? did you test it?

Yes. Ill Update the BEFORE and AFTER's with new Info

[ankitsmt211]

looks good, thanks :)

[SquidXTV]

<3