Skip to content

refactor HelpThreadCreatedListener - #1078

Merged
Taz03 merged 2 commits into
Together-Java:developfrom
ankitsmt211:bugfix/unknown-message
Apr 13, 2024
Merged

refactor HelpThreadCreatedListener#1078
Taz03 merged 2 commits into
Together-Java:developfrom
ankitsmt211:bugfix/unknown-message

Conversation

@ankitsmt211

@ankitsmt211 ankitsmt211 commented Mar 26, 2024

Copy link
Copy Markdown
Member

Resolving error:
image

more context for bugfix : discord conversation

replacing onChannelCreate with onMessageRecieved for HelpThreadCreatedListenerFlow this also ensures that we no longer need additional delay in creating automated response or gpt response. Not only makes code a bit less complex but also possibly resolves this error around unknown message

  • move write to db in a method
  • use messageRecieved instead of onChannelCreate
  • rename createMessages to generateAutomatedResponse
  • chain generateAutomatedResponse and pinOriginal to retreiveMessage rest action

* move write to db in a method
* use messageRecieved instead of onChannelCreate
* rename createMessages to generateAutomatedResponse
* chain generateAutomatedResponse and pinOriginal to retreiveMessage rest action
@ankitsmt211
ankitsmt211 requested a review from a team as a code owner March 26, 2024 11:03
@ankitsmt211 ankitsmt211 added bug Something isn't working priority: major labels Mar 26, 2024
tj-wazei
tj-wazei previously approved these changes Apr 6, 2024
@ankitsmt211
ankitsmt211 requested a review from tj-wazei April 6, 2024 15:31
@Taz03
Taz03 dismissed a stale review April 13, 2024 02:32

cr

@Taz03
Taz03 merged commit 7490beb into Together-Java:develop Apr 13, 2024
@ankitsmt211 ankitsmt211 mentioned this pull request Apr 13, 2024
@ankitsmt211
ankitsmt211 deleted the bugfix/unknown-message branch April 14, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: major

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants