chore: rename ban history options to be clearer - #1082
Conversation
|
I would say the description needs to be updated as well:
if the options are |
|
Would |
Well wouldn't it be even fine to just simplify it to |
|
I approved for the renaming of things but the ban command in it's logic looks incorrect to me (out of scope for Simon). The Bulk Message Delete API https://discord.com/developers/docs/resources/channel#delete-message You can delete messages that are younger than 2 weeks. The API can only delete a maximum of 100 messages. Which means for us to do a whole weeks worth of messages, we'd have to make multiple API calls in batches of 100. Something to look into. Maybe create a new Issue for investigation? |
|
i dont mind. so far it wasnt a problem. afaik these choices are passed directly as they are to the API and align with the options u have when u ban through the native discord UI without our command. and thats fine. |
Updates the delete history options as follows:
recent => day
all => week
To make how much is cleared clearer.
Resolves #1081