Skip to content

chore: add safety checks to NoteCommand #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tj-wazei merged 2 commits into from
May 6, 2024
Merged

chore: add safety checks to NoteCommand #1086

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fc11cc
chore: add safety checks to NoteCommand
SimonVerhoeven Apr 13, 2024
717ad50
chore: apply spotless
SimonVerhoeven Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions application/src/main/java/org/togetherjava/tjbot/features/moderation/NoteCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,13 @@ public NoteCommand(ModerationActionsStore actionsStore) {

@Override
public void onSlashCommand(SlashCommandInteractionEvent event) {
OptionMapping targetOption = event.getOption(USER_OPTION);
Member author = event.getMember();
Guild guild = event.getGuild();
String content = event.getOption(CONTENT_OPTION).getAsString();
OptionMapping targetOption =
Objects.requireNonNull(event.getOption(USER_OPTION), "The user is null");
Member author = Objects.requireNonNull(event.getMember());
Guild guild = Objects.requireNonNull(event.getGuild());
String content =
Objects.requireNonNull(event.getOption(CONTENT_OPTION), "The content is null")
.getAsString();
Comment thread
tj-wazei marked this conversation as resolved.

if (!handleChecks(guild.getSelfMember(), author, targetOption.getAsMember(), content,
event)) {
Expand Down