Skip to content

Fix: Pinned Threads Archiving Issue #1084 - #1104

Closed
JayBhensdadia wants to merge 1 commit into
Together-Java:developfrom
JayBhensdadia:fix/pinned-threads-should-not-be-archived
Closed

Fix: Pinned Threads Archiving Issue #1084 #1104
JayBhensdadia wants to merge 1 commit into
Together-Java:developfrom
JayBhensdadia:fix/pinned-threads-should-not-be-archived

Conversation

@JayBhensdadia

Copy link
Copy Markdown

This pull request solves the problem outlined in issue #1084, where pinned threads in the "questions" forum were being archived by the auto-archiving routine.

Testing:
For testing purposes i used SCHEDULE_MINUTES = 1 and ARCHIVE_AFTER_INACTIVITY_OF = 100 seconds

Screenshots:

before PR

After INACTIVITY

after PR

Screen recording of test

@JayBhensdadia
JayBhensdadia requested a review from a team as a code owner May 5, 2024 10:04
@CLAassistant

CLAassistant commented May 5, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Taz03

Taz03 commented May 7, 2024

Copy link
Copy Markdown
Contributor

A fix for this is already merged ( #1088 )

@SimonVerhoeven

Copy link
Copy Markdown
Contributor

Ideally first look if a ticket's already assigned, and whether there's already an open pull request for it.

@JayBhensdadia

Copy link
Copy Markdown
Author

Okay, thanks
I got it. It was my first contribution.

@ankitsmt211

Copy link
Copy Markdown
Member

@JayBhensdadia Hi, will be closing this PR soon unless you any further questions.

@JayBhensdadia

Copy link
Copy Markdown
Author

No, I don't have any questions
You can close it.
Thanks!

@ankitsmt211

Copy link
Copy Markdown
Member

sweet, hope to see you around :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants