Skip to content

Create .gitattributes - #1108

Merged
Zabuzard merged 1 commit into
Together-Java:developfrom
surajkumar:gitattributes
May 13, 2024
Merged

Create .gitattributes#1108
Zabuzard merged 1 commit into
Together-Java:developfrom
surajkumar:gitattributes

Conversation

@surajkumar

Copy link
Copy Markdown
Contributor

Created a .gitattributes to enforce LF encoding. On Windows when I ran spotless, it changes the line encoding to CFRL which is incorrect.

@surajkumar
surajkumar requested a review from a team as a code owner May 12, 2024 17:31

@Zabuzard Zabuzard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about existing code? If this is ticked, will tooling suddenly report that some existing code has the wrong file endings?
If so, it has to be changed in the same PR as well.

@Zabuzard Zabuzard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(wazei says on discord that all files are already LF)

@Zabuzard
Zabuzard merged commit f045ccf into Together-Java:develop May 13, 2024
@surajkumar
surajkumar deleted the gitattributes branch May 13, 2024 18:18
@ankitsmt211 ankitsmt211 mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants