Skip to content

Refactor help thread creation workflow - #1112

Merged
ankitsmt211 merged 1 commit into
developfrom
feature/refactor-question-creation-flow
May 15, 2024
Merged

Refactor help thread creation workflow#1112
ankitsmt211 merged 1 commit into
developfrom
feature/refactor-question-creation-flow

Conversation

@SquidXTV

Copy link
Copy Markdown
Member

resolves #1111

About

This slightly improves the help thread creation workflow by reusing already gathered Message.

@SquidXTV
SquidXTV requested a review from a team as a code owner May 13, 2024 18:22
@sonarqubecloud

Copy link
Copy Markdown

@ankitsmt211 ankitsmt211 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid, good job flow is much easier to look at with refactor.

@SquidXTV

Copy link
Copy Markdown
Member Author

yeah kinda annoying with all these any in the lambdas.
I hope we update to java 22 soon, which lets us replace them with _

@ankitsmt211
ankitsmt211 merged commit d3a19aa into develop May 15, 2024
@ankitsmt211
ankitsmt211 deleted the feature/refactor-question-creation-flow branch May 15, 2024 08:27
@ankitsmt211 ankitsmt211 mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor thread creation flow

3 participants