[WIP] Use git pull to update pedalboards#144
Closed
sastraxi wants to merge 8 commits into
Closed
Conversation
sastraxi
changed the title
rreichenbach
left a comment
rreichenbach
left a comment
Collaborator
There was a problem hiding this comment.
The new Notice is a useful feature.
This isn't quite working as I would expect though. With a clean pi-Stomp install (no pedalboard changes), if I add to my config:
pedalboards: https://github.com/TreeFallSound/pi-stomp-pedalboards
I get the Remote Mismatch Notice.
If you make any changes, it would be helpful to contextualize the notification messages so that the user knows there are regarding Pedalboard syncing.
sastraxi
force-pushed
the
feat/sync-pedalboards
branch
from
4f4431a to
f72e17f
Compare
… + reload_pedalboard feat/sync-pedalboards drives MOD-UI change detection via a FileChangeMonitor on last.json and reload_pedalboard(bundle) to refresh plugin state from disk. feat/v1v2-emulator's EmulatorModhandler short-circuits to set_current_pedalboard(pedalboard) without invoking the reload pipeline. Why: in the emulator, changing the bundle from MOD-Desktop must trigger the same reload-from-TTL path the device uses, or plugin state on the LCD goes stale. How to apply: in emulator/modhandler.py wire FileChangeMonitor for last.json and route pedalboard_change() through reload_pedalboard(bundle) before set_current_pedalboard. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Collaborator
Author
|
I no longer believe this is the right approach. I think we need a larger design discussion around how updates work in general -- pedalboards, user files, LV2 plugins, pi-stomp and mod-ui versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the "Update sample pedalboards" flow (which ran a script that overwrote the sample pedalboards from a fixed remote) with "Sync pedalboards", which pulls/merges from a user-configured git remote. This config value lives in default_config.yml, e.g.
Local edits are preserved across syncs, to the extent git allows it. Update status (including conflicts) show up on the LCD. This includes:
Persistent notification icon
A new orange alert icon appears on the LCD whenever the last sync attempt left a problem (conflicts, network error, remote mismatch, etc.) — so the user knows their pedalboards are out of sync without re-opening the menu. It clears automatically once a sync succeeds.
First-boot behavior
If ~/.pedalboards is missing/empty and a remote is configured, pi-stomp clones it automatically at startup rather than requiring the user to SSH in. This supplements the behaviour provided by pi-gen-pistomp et al.