Normalize instance_id once at the source#162
Merged
sastraxi merged 4 commits intoJun 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A plugin's
instance_idwas inconsistently formatted: sometimes with a leading/from LILV parsing, sometimes without. This meant creating the right REST URLs was a bit error-prone. I tried to fix this earlier, but my fix actually broke snapshot changing (the regression you saw @rreichenbach when reviewing #150).LCD code had .replace("/", "") hacks to strip slashes that shouldn't have been there, and it felt like we could do better.
The fix: normalize at the single source (LILV parser), add defensive lstrips in Parameter and Plugin, and remove the definsive programming from LCD and WebsocketBridge.
Now instance_id is always canonical ("CollisionDrive", never "/CollisionDrive"), and every consumer can trust it.
Tested on the v1/v3 emulator (the bug was reproducible there, too).
Branch stack