chore: retire T3 Code provenance leftovers - #349
Merged
Merged
Conversation
The Codex developer instructions told the model it was running inside "T3 Code" and named a nonexistent `t3-code` MCP server; the real server is `tcode_preview`. Reword that section for tcode and replace the module's "wire-exact, do not paraphrase" claim with the constraint that actually exists (the <proposed_plan> / request_user_input / update_plan contract shared with the Codex adapter and plan UI). Elsewhere, comments that said "mirrors T3's X" / "T3's exact" / "verbatim" pointed at identifiers in another codebase and implied the text was frozen for compatibility that no longer exists. Rewrite them to describe what the code does. Provenance-named tests are renamed after the behavior they check. Kept: SourceTool::T3Code and T3 transcript import compatibility, README acknowledgement, test fixture ids, and the T0..T3 material tiers from docs/DESIGN.md (unrelated to T3 Code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
tcode was ported from T3 Code. Two kinds of leftovers remained on main:
crates/agent/src/codex/developer_instructions.rs(since 09714df) told Codex "You are running inside T3 Code. Thet3-codeMCP server is…". There is no such server; ours istcode_preview. The module doc also claimed the text was "wire-exact, do not paraphrase" for T3's sake, which is not a real constraint.foo", "ported fromBar.ts", "T3's exact message", "T3 verbatim prefix") that point at identifiers in a codebase not in this repo and imply frozen text. They misled maintainers about what may be edited.What
tcode_preview; substance unchanged. Plan/Default mode bodies untouched. Module doc states the actual coupling: the<proposed_plan>block andrequest_user_input/update_planrules are consumed by the Codex adapter and plan UI.error_copy_is_t3_verbatim,serialize_matches_t3,token_format_matches_t3, …) renamed after the behavior they assert.Kept on purpose:
SourceTool::T3Codeand the T3 transcript import path (real compatibility), README acknowledgement, test fixture ids, and the T0..T3 material tiers indocs/DESIGN.md/material.rs(a surface tier, unrelated to T3 Code).No behavior change apart from the developer-instructions string sent to Codex.
Checks
cargo fmt --all --check,cargo check --workspace,cargo test -p agent -p tcode-core -p tcode-services -p preview-mcp -p tcode-ui -p tcode-runtimeall pass.Related: #348 moved the preview_status → preview_open guidance into the tool descriptions so non-Codex providers get it too; Codex now receives it in both places, which is harmless.