Potential fix for code scanning alert no. 21: Incomplete URL scheme check#2765
Closed
nperez0111 wants to merge 2 commits into
Closed
Potential fix for code scanning alert no. 21: Incomplete URL scheme check#2765nperez0111 wants to merge 2 commits into
nperez0111 wants to merge 2 commits into
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The multi-line if condition moved the 'javascript:' string to a line no longer covered by the eslint-disable-next-line directive. Move the comment inside the if condition so it correctly suppresses no-script-url on the line containing the string literal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/TypeCellOS/BlockNote/security/code-scanning/21
The best fix is to explicitly block all known dangerous executable schemes in this sanitizer, not just
javascript:.Without changing existing behavior otherwise, update the condition in
packages/react/src/util/sanitizeUrl.tsso the function only returnsurl.hrefwhen the protocol is not any of:javascript:,data:,vbscript:. For blocked schemes (or parse errors), continue returning"#"exactly as now.Concretely, edit the
ifon line 12 region to include all three checks. No new imports, methods, or dependencies are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.