Allow FilePanel override in replace panel - #3066
Conversation
|
Someone is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthrough
ChangesFile replacement panel
Priority: ⬇️ Low — Defer the optional FilePanel override because it is a narrow, backward-compatible extension to FileReplaceButton and its Uppy example. Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to File replacement panels can now be customized while existing consumers retain the default panel behavior. The Uppy example uses the shared extension point, with no concrete current-head merge risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit finds a panel bright Comment |
Adds support for overriding the file panel rendered by
FileReplaceButton.Rationale
Applications using a custom file panel currently need to copy and maintain the entire
FileReplaceButtonimplementation. This change allows the same custom upload UI or tab configuration to be reused when adding and replacing files.Changes
filePanelprop toFileReplaceButtonFilePanelas the default when no override is providedFileReplaceButtonimplementationImpact
The change is backward compatible. Existing applications that do not provide
filePanelcontinue to receive the default file panel.Testing
03-ui-components/11-uppy-file-panelexampleChecklist
Additional Notes
The Uppy file-panel example demonstrates using the same custom panel for both new file uploads and file replacement.