Skip to content

fix: RangeError when un-nesting certain blocks#797

Open
matthewlipski wants to merge 1 commit into
mainfrom
block-unnest-fix
Open

fix: RangeError when un-nesting certain blocks#797
matthewlipski wants to merge 1 commit into
mainfrom
block-unnest-fix

Conversation

@matthewlipski
Copy link
Copy Markdown
Collaborator

This PR fixes an error caused when trying to un-nest blocks which have children.

Closes #481
Closes #598

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Jun 3, 2024 4:52pm
blocknote-website ✅ Ready (Inspect) Visit Preview Jun 3, 2024 4:52pm

Copy link
Copy Markdown
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this introduces some bugs:

bug nesting

@sb8244
Copy link
Copy Markdown

sb8244 commented Aug 4, 2024

May be unrelated, I'm attempting to use this function to fix liftListItem in a function I'm creating.

The result when calling it is that all indentation is removed. So instead of going up 1 level, it goes to the root.

It may be a side effect of the function I'm writing (trying to have sinkListItem only affect the single node that's selected) though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting RangeError: Invalid content for node blockContainer: && Nested block deletion bug RangeError: Invalid content for node blockcontainer

3 participants