Make media file filters provider-aware - #655
Open
CoffeeFlux wants to merge 4 commits into
Open
Conversation
CoffeeFlux
marked this pull request as ready for review
August 3, 2026 21:52
Member
|
Wouldn't it be better to add functions to query the supported file formats in the |
Member
Author
|
I think they're needed relatively early in initialization, but this should keep the ifdef spam in one space. |
arch1t3cht
approved these changes
Aug 14, 2026
arch1t3cht
left a comment
arch1t3cht
left a comment
Member
There was a problem hiding this comment.
Added a small fix commit to fix some indentation, LGTM otherwise. However, this PR does change existing strings so it'll need to be merged after the 3.5 release. Let me know if you have any other patches depending on this one, then I can merge it on master and make a 3.5 freeze branch.
Member
Author
|
Nah, this one can wait.
…On Fri, Aug 14, 2026 at 8:46 AM arch1t3cht ***@***.***> wrote:
***@***.**** approved this pull request.
Added a small fix commit to fix some indentation, LGTM otherwise. However,
this PR does change existing strings so it'll need to be merged after the
3.5 release. Let me know if you have any other patches depending on this
one, then I can merge it on master and make a 3.5 freeze branch.
—
Reply to this email directly, view it on GitHub
<#655?email_source=notifications&email_token=AAYIODR3462NLGEKAY7TKJL5J4X4LA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJTHA4TGMZVGU2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4938933554>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYIODUCU6YXF7ALJ4H33YT5J4X4LAVCNFSNUABFKJSXA33TNF2G64TZHMYTENZSGQZDEOBTHNEXG43VMU5TKMBVGQYDCMRSGMYKC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AAYIODTPOSEOGPV7HV2YPHD5J4X4LA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJTHA4TGMZVGU2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AAYIODQPAM3HHZMEVJ2FQFT5J4X4LA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJTHA4TGMZVGU2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Ryan Lucia
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47