Skip to content

[INTERNAL] Add preliminary guide for v3 migration#608

Merged
matz3 merged 6 commits into
masterfrom
docs-migrate-v3
Apr 6, 2022
Merged

[INTERNAL] Add preliminary guide for v3 migration#608
matz3 merged 6 commits into
masterfrom
docs-migrate-v3

Conversation

@matz3

@matz3 matz3 commented Mar 25, 2022

Copy link
Copy Markdown
Member

No description provided.

@matz3
matz3 requested review from codeworrior and ecker March 29, 2022 08:59
Comment thread docs/pages/Builder.md
@matz3
matz3 requested a review from KlattG April 4, 2022 11:36

@KlattG KlattG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions, otherwise LGTM

Comment thread docs/updates/migrate-v3.md Outdated
Comment thread docs/updates/migrate-v3.md Outdated
Comment thread docs/updates/migrate-v3.md Outdated
matz3 and others added 2 commits April 4, 2022 14:52
Co-authored-by: KlattG <57760635+KlattG@users.noreply.github.com>
@KlattG

KlattG commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

LGTM

KlattG
KlattG previously approved these changes Apr 5, 2022
codeworrior
codeworrior previously approved these changes Apr 5, 2022

@codeworrior codeworrior left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matz3
matz3 dismissed stale reviews from codeworrior and KlattG via 7eb2369 April 6, 2022 06:52
@matz3
matz3 requested a review from KlattG April 6, 2022 06:57

@codeworrior codeworrior left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LEBTM ;-)

@ecker ecker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done!

@matz3
matz3 merged commit d9433ce into master Apr 6, 2022
@matz3
matz3 deleted the docs-migrate-v3 branch April 6, 2022 07:10

@KlattG KlattG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

d3xter666 added a commit that referenced this pull request Sep 24, 2025
…608)

Resolves: #809

When shimmed packages are defined as dependency aliases in the
package.json, they are being excluded from the bundlig as the packager
eventually finds the real package and its path and as it's not defined
in the shim, but its alias, it gets ignored.

We need to provide more robust discovery in order to handle those cases:
- npm/cli#3
-
https://github.com/npm/rfcs/blob/main/implemented/0001-package-aliases.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants