mc_GenPath make (both parent and dir) modes fail when path includes double slashes

[dankessler]

@shijiaguo noticed this and brought it to my attention. It seems reproducible.

If you try running mc_GenPath in either 'makedir' or 'makeparentdir' modes, matlab will attempt to call its native mkdir function. However, if you pass it something with multiple file system delimiters (e.g. '/net//data4/test1/test2') it will fail. You can very simply replicate this with the following code bits

e.g. (assuming you have permissions to do all this)
mkdir('~/test1/test2/test3/test4') will work
mkdir('~/test1//test2/test3/test4') will not

Not sure of best solution. Maybe @mangstad has an idea?

[mangstad]

yeah, I actually just recently noticed this as well and forgot to post a comment about it. I think mc_GenPath should just do an initial search through the string to replace all occurrences of multiple delimiters (using filesep) with a single one.

-----Original Message-----
From: Daniel A Kessler [mailto:reply+i-4801560-
9c8c67feb70a2f29efac33d1587a0ce1e253aadc-1479722@reply.github.com]
Sent: Tuesday, May 29, 2012 2:51 PM
To: Angstadt, Mike
Subject: [MethodsCore] mc_GenPath make (both parent and dir) modes fail
when path includes double slashes (#58)

@shijiaguo noticed this and brought it to my attention. It seems
reproducible.

If you try running mc_GenPath in either 'makedir' or 'makeparentdir'
modes, matlab will attempt to call its native mkdir function. However, if you
pass it something with multiple file system delimiters (e.g.
'/net//data4/test1/test2') it will fail. You can very simply replicate this with
the following code bits

e.g. (assuming you have permissions to do all this)
mkdir('~/test1/test2/test3/test4') will work
mkdir('~/test1//test2/test3/test4') will not

Not sure of best solution. Maybe @mangstad has an idea?

---

Reply to this email directly or view it on GitHub:
#58

---

Electronic Mail is not secure, may not be read every day, and should not be used for urgent or sensitive issues

[dankessler]

Sounds good to me. Very similar to what @sripada proposed, but I think
using filesep will keep it system non-specific. Do you want to take on the
fix, or should somebody else tackle?

On Tue, May 29, 2012 at 3:24 PM, Mike Angstadt <
reply@reply.github.com

wrote:

yeah, I actually just recently noticed this as well and forgot to post a
comment about it. I think mc_GenPath should just do an initial search
through the string to replace all occurrences of multiple delimiters (using
filesep) with a single one.

-----Original Message-----
From: Daniel A Kessler [mailto:reply+i-4801560-
9c8c67feb70a2f29efac33d1587a0ce1e253aadc-1479722@reply.github.com]
Sent: Tuesday, May 29, 2012 2:51 PM
To: Angstadt, Mike
Subject: [MethodsCore] mc_GenPath make (both parent and dir) modes fail
when path includes double slashes (#58)

@shijiaguo noticed this and brought it to my attention. It seems
reproducible.

If you try running mc_GenPath in either 'makedir' or 'makeparentdir'
modes, matlab will attempt to call its native mkdir function. However,
if you
pass it something with multiple file system delimiters (e.g.
'/net//data4/test1/test2') it will fail. You can very simply replicate
this with
the following code bits

e.g. (assuming you have permissions to do all this)
mkdir('~/test1/test2/test3/test4') will work
mkdir('~/test1//test2/test3/test4') will not

Not sure of best solution. Maybe @mangstad has an idea?

---

Reply to this email directly or view it on GitHub:
#58

---

Electronic Mail is not secure, may not be read every day, and should not
be used for urgent or sensitive issues

---

Reply to this email directly or view it on GitHub:

#58 (comment)

Daniel A. Kessler
Research Area Computer Specialist
Psychiatry - Rachel Upjohn Building
University of Michigan, Ann Arbor
kesslerd@umich.edu
+1 734.418.8134

[mangstad]

well, I just ran a quick test and this should be the fix if you want to go ahead and stick it in. This should probably be the first thing that happens in the function:

myinputdirectory = regexprep(myinputdirectory,[filesep '+'],filesep);

This will do a regular expression replacement and replace any spots where filesep occurs 1 or more times with 1 occurrence of filesep

---

Electronic Mail is not secure, may not be read every day, and should not be used for urgent or sensitive issues