Fixed improper verification of the mocha installation#1585
Merged
Conversation
rudolf101
added
ctg-bug
denis-fokin
reviewed
Dec 23, 2022
| bufferedReader.close() | ||
| if (checkForPackageText == "") { | ||
| val packages = bufferReader.readText() | ||
| bufferReader.close() |
Collaborator
There was a problem hiding this comment.
Is that correct that you close the reader for the input stream and do not close for the error stream (which is created in runCommand)?
denis-fokin
approved these changes
Dec 26, 2022
tamarinvs19
pushed a commit
that referenced
this pull request
Jan 9, 2023
alisevych
added
ctg-bug-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now the installed mocha package is checked correctly, if there is a local mocha installation, the window with the installation suggestion does not appear.
Fixes #1582
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Manually
Manual Scenario
Checklist (remove irrelevant options):
This is the author self-check list