Fix casts in overflow checking function#2024
Merged
Merged
Conversation
Markoutte
approved these changes
Mar 24, 2023
Markoutte
left a comment
Collaborator
There was a problem hiding this comment.
I think we need discuss more about this feature, because, it can have strange behavior from user point of view. For example, we have this test be reported as it has overflow, but in real life it does not:
public static int foo(byte a, short b) {
return a + b;
}
Despite this, I think this fix should be merged as is, because it fixes critical problem.
Member
Author
Agree, created an issue for it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the wrong way to cast primitive values in the function related to overflowing checks
Description
Added an explicit cast for arguments of the check function. They were wrapped into a primitive value that didn't change their symbolic type. That led to an error where we process primitive values of different sorts.
Fixes #2022
How to test
Automated tests
org.utbot.examples.math.OverflowAsErrorTest#testByteWithIntOverflowManual tests
I tested the example from the issue and a similar one. Note that an example from the issue doesn't contain overflow since
+casts both operands to an int type, therefore, since the second one is a constant and the first one is a byte value, an integer overflow can never occur. If we transform the second value into a symbolic value, we'll find an overflow error.Self-check list