Support using identifiers generated by database as method arguments#2285
Merged
Conversation
Markoutte
approved these changes
Jun 14, 2023
…valuating into `null`
Markoutte
approved these changes
Jun 15, 2023
EgorkaKulikov
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For reproduceable tests for methods that can read database and accept identifiers, we want to first fill up the database, take some identifier generated by the database and then pass that identifier to the method under test. That also solves the problem of fuzzer not always being able to guess identifiers that are used by the database, for example, when database uses random UUIDs.
How to test
Manual tests
Generate tests for
OrderService#deleteOrderById(Long)fromspring-boot-testing-mainproject, there should be test that looks like this:Self-check list