Skip to content

Fix incorrect analysis steps in the SARIF report#249

Merged
mmvpm merged 2 commits into
mainfrom
ideaseeker/incorrect-analysis-steps-in-sarif-report
Jun 21, 2022
Merged

Fix incorrect analysis steps in the SARIF report#249
mmvpm merged 2 commits into
mainfrom
ideaseeker/incorrect-analysis-steps-in-sarif-report

Conversation

@mmvpm

@mmvpm mmvpm commented Jun 20, 2022

Copy link
Copy Markdown
Collaborator

Description

Fix incorrect analysis steps in the SARIF report generated for the class with a private function.

Fixes #247

Type of Change

  • Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Automated Testing

org.utbot.sarif.SarifReportTest

Manual Scenario

Repeat the steps from the issue #247

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • No new warnings
  • All tests pass locally with my changes

@mmvpm mmvpm requested a review from SBOne-Kenobi June 20, 2022 10:40
@mmvpm mmvpm self-assigned this Jun 20, 2022

@SBOne-Kenobi SBOne-Kenobi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are any tests that represent this bug?

@SBOne-Kenobi SBOne-Kenobi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmvpm mmvpm force-pushed the ideaseeker/incorrect-analysis-steps-in-sarif-report branch from 222d68f to 736abbf Compare June 21, 2022 08:23
@mmvpm mmvpm merged commit 694a768 into main Jun 21, 2022
@mmvpm mmvpm deleted the ideaseeker/incorrect-analysis-steps-in-sarif-report branch June 21, 2022 09:52
mmvpm added a commit that referenced this pull request Jun 22, 2022
* #247 Fix incorrect analysis steps in the sarif report
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect analysis steps in the SARIF report for private functions

2 participants