ML path selector#99
Merged
Merged
Conversation
Atos1337
force-pushed
the
Atos1337/ml-only-path-selector
branch
from
aba9586 to
4aed1a3
Compare
Member
Author
|
Comments about docs also appreciated |
CaelmBleidd
requested changes
Jun 4, 2022
CaelmBleidd
left a comment
CaelmBleidd
left a comment
Member
There was a problem hiding this comment.
Some small comment
It's better to request a review for such PRs (with ml and non-ml changes) from someone from ml team as well. I think @amandelpie could help us with it
Atos1337
force-pushed
the
Atos1337/ml-only-path-selector
branch
from
7dddbc5 to
899fe07
Compare
amandelpie
requested changes
Jun 10, 2022
amandelpie
left a comment
amandelpie
left a comment
Collaborator
There was a problem hiding this comment.
First part of comments
amandelpie
requested changes
Jun 10, 2022
amandelpie
left a comment
amandelpie
left a comment
Collaborator
There was a problem hiding this comment.
A lot of my comments are related to poor documentation and unclear logic.
I also need a time to debug and reproduce results
amandelpie
approved these changes
Jun 14, 2022
amandelpie
left a comment
amandelpie
left a comment
Collaborator
There was a problem hiding this comment.
I suppose that @Atos1337 fixed a lot of proposed changes and the PR could be merged
added 18 commits
June 15, 2022 10:24
Atos1337
force-pushed
the
Atos1337/ml-only-path-selector
branch
from
0325ddf to
bec49b0
Compare
CaelmBleidd
approved these changes
Jun 15, 2022
CaelmBleidd
left a comment
CaelmBleidd
left a comment
Member
There was a problem hiding this comment.
Please, add a proper description for the request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation of new heuristical-based selectors: CPInstSelector, SubpathGuidedSelector and ForkDepthSelector.
New ml-based path selector, which was proposed in relative issue.
Fixes #37
Type of Change
How Has This Been Tested?
Automated Testing
Tests for predictors in: org.utbot.predictors
Tests for featureProcessor in: org.utbot.features
Manual Scenario
You can generate tests with new selector:
Predictors.stateRewardPredictor = ...in ContestEstimator.ktUtSettings.pathSelectorType=NN_REWARD_GUIDED_SELECTORUtSettings.rewardModelPath="path/to/model"