fix: resolve typecheck errors across packages - #139
Merged
Conversation
Collaborator
|
yeah its probably time i set up a CI script to catch these |
RhysSullivan
pushed a commit
that referenced
this pull request
May 31, 2026
* fix(react): add vite/client types to resolve import.meta.env errors * fix: use turbo for typecheck to respect task graph dependencies * fix(core): add missing @types/node for sdk and storage-file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vite/clienttypes to@executor/reactforimport.meta.envresolutiontypecheckscript toturbo run typecheckto respect task graph dependencies@types/nodetosdkandstorage-filepackages that use Node APIsTest plan
turbo run typecheckpasses cleanly