Skip to content

fix: harden oauth popup handshake - #141

Merged
RhysSullivan merged 2 commits into
UsefulSoftwareCo:mainfrom
aryasaatvik:fix/oauth-popup-handshake
Apr 9, 2026
Merged

fix: harden oauth popup handshake#141
RhysSullivan merged 2 commits into
UsefulSoftwareCo:mainfrom
aryasaatvik:fix/oauth-popup-handshake

Conversation

@aryasaatvik

Copy link
Copy Markdown
Contributor

Summary

  • keep OAuth waiting state active until an actual callback result arrives
  • add BroadcastChannel fallback for popup callback delivery
  • add explicit cancel controls for MCP and Google Discovery OAuth waiting states

Verification

  • bun run --cwd packages/plugins/mcp typecheck
  • bun run --cwd packages/plugins/google-discovery typecheck
  • bun run --cwd packages/plugins/mcp test
  • bun run --cwd packages/plugins/google-discovery test

Note: apps/local typecheck still fails on an unrelated existing core API type mismatch in packages/core/api/src/handlers/executions.ts.

@RhysSullivan
RhysSullivan marked this pull request as ready for review April 9, 2026 22:08
@RhysSullivan
RhysSullivan merged commit 028b28f into UsefulSoftwareCo:main Apr 9, 2026
RhysSullivan pushed a commit that referenced this pull request May 31, 2026
* fix(mcp): harden oauth popup handshake

* fix(google-discovery): harden oauth popup handshake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants