fix: resolve typecheck failures with proper Effect tagged errors - #147
Merged
Conversation
Replace all @effect/language-service diagnostic suppressions with proper tagged error types. Remove every `globalErrorInEffectCatch`, `globalErrorInEffectFailure`, and `unknownInEffectCatch` disable across all tsconfigs. - Add PromiseAdapterError + fromPromiseTagged helper in promise-executor for typed Promise→Effect error bridging with runtime _tag checking - Replace `as ToolId` / `as SecretId` etc. casts with Brand.make() calls - Add ServiceAdapterError + tryPromiseService in cloud auth layer - Replace `Effect.fail(new Error(...))` with OrganizationNotFoundError - Split PausedExecution into public (id + context) and internal (+ Deferred/Fiber/Ref) types so consumers don't see Effect internals - Fix resume handler to discriminate completed vs paused results - Clean up server.test.ts: extract withClient, textOf, makePausedResult, makeElicitingEngine helpers; remove all try/finally boilerplate - Remove unused imports in tool-invoker.test.ts
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | b25ca0d | Apr 10 2026, 04:50 AM |
RhysSullivan
added a commit
that referenced
this pull request
May 31, 2026
Replace all @effect/language-service diagnostic suppressions with proper tagged error types. Remove every `globalErrorInEffectCatch`, `globalErrorInEffectFailure`, and `unknownInEffectCatch` disable across all tsconfigs. - Add PromiseAdapterError + fromPromiseTagged helper in promise-executor for typed Promise→Effect error bridging with runtime _tag checking - Replace `as ToolId` / `as SecretId` etc. casts with Brand.make() calls - Add ServiceAdapterError + tryPromiseService in cloud auth layer - Replace `Effect.fail(new Error(...))` with OrganizationNotFoundError - Split PausedExecution into public (id + context) and internal (+ Deferred/Fiber/Ref) types so consumers don't see Effect internals - Fix resume handler to discriminate completed vs paused results - Clean up server.test.ts: extract withClient, textOf, makePausedResult, makeElicitingEngine helpers; remove all try/finally boilerplate - Remove unused imports in tool-invoker.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@effect/language-servicediagnostic suppressions (globalErrorInEffectCatch,globalErrorInEffectFailure,unknownInEffectCatch) with properly typed tagged errors across the monorepoPromiseAdapterError+fromPromiseTaggedhelper inpromise-executor.tsthat runtime-checks rejection_tagfields against an allow-list, re-raising matches as typed failures and dying on unexpected errorsas ToolId/as SecretId/as ScopeIdType/as PolicyIdcasts withBrand.make()callsPausedExecutioninto a public type (id+elicitationContext) and an internal type (+Deferred/Fiber/Ref) so consumers don't depend on Effect runtime internalsserver.test.ts: extractwithClient,textOf,makePausedResult,makeElicitingEnginehelpers; eliminate alltry/finallyboilerplate andas anycastsTest plan
turbo run typecheckpasses 27/27 packages with zero warningsvitest runpasses for@executor/host-mcp(23 tests)