fix: resolve CI test failures - #153
Merged
Merged
Conversation
- Increase hookTimeout for storage-postgres tests (PGlite init + migrations can exceed the 10s default in CI) - Skip keychain system-keychain tests in CI (no keychain service)
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| 🔵 In progress View logs |
executor-marketing | 5b6440e | Apr 10 2026, 08:21 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 5b6440e | Commit Preview URL Branch Preview URL |
Apr 10 2026, 08:22 AM |
RhysSullivan
added a commit
that referenced
this pull request
May 31, 2026
* fix: resolve CI test failures - Increase hookTimeout for storage-postgres tests (PGlite init + migrations can exceed the 10s default in CI) - Skip keychain system-keychain tests in CI (no keychain service) * style: format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hookTimeoutto 30s for storage-postgres tests — PGlite initialization + Drizzle migrations exceed the 10s default in CIit.effect.skipIf(!!process.env.CI)) since there's no keychain service availableTest plan
storage-postgrestests pass locallykeychaintests skip correctly withCI=1