refactor: batch KV set and delete operations - #173
Merged
Conversation
Change Kv.set to accept an array of {key, value} entries and Kv.delete
to accept an array of keys. Postgres implementation uses single INSERT
ON CONFLICT and DELETE WHERE IN queries instead of per-item statements.
For a 218-tool OpenAPI spec, this reduces source add from ~218 INSERT
statements to 1, and source delete from ~218 DELETEs to 1.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | c054d1f | Apr 10 2026, 09:27 PM |
RhysSullivan
force-pushed
the
refactor/batch-kv-operations
branch
2 times, most recently
from
April 10, 2026 21:24
fd872c3 to
fc729c7
Compare
RhysSullivan
added a commit
that referenced
this pull request
May 31, 2026
* refactor: batch KV set and delete operations
Change Kv.set to accept an array of {key, value} entries and Kv.delete
to accept an array of keys. Postgres implementation uses single INSERT
ON CONFLICT and DELETE WHERE IN queries instead of per-item statements.
For a 218-tool OpenAPI spec, this reduces source add from ~218 INSERT
statements to 1, and source delete from ~218 DELETEs to 1.
* style: format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kv.setnow takesreadonly KvEntry[]instead of single key/valueKv.deletenow takesreadonly string[]instead of single keyINSERT ON CONFLICT/DELETE WHERE INqueriesTest plan