can't uninstall deprecated plugin fix - #8550
Open
UvuvDev wants to merge 2 commits into
Open
Conversation
Legacy extension migration reused Extension::Install, which rejects deprecated plugins. That's correct for fresh installs from the marketplace, but it also blocked migrating a plugin the user already had installed under the previous extension manager -- if the plugin had since been deprecated, it could never be registered as installed again, and so could never be uninstalled either. InstallForMigration is the same call with only the deprecation guard lifted, intended for use by the migration path only. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
New C API function affects linking, per the project's own convention for BN_CURRENT_CORE_ABI_VERSION. Not a breaking change, so BN_MINIMUM_CORE_ABI_VERSION is unchanged. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
fuzyll
requested changes
Sep 13, 2026
fuzyll
left a comment
fuzyll
left a comment
Contributor
There was a problem hiding this comment.
Assuming the internal PR is accepted, these are the changes I would want to this API one.
| bool Uninstall(); | ||
| bool CancelUninstall(); | ||
| bool Install(std::string versionID); | ||
| // Like Install, but also permits installing a version of a plugin that has since been marked |
Contributor
There was a problem hiding this comment.
Don't leave these AI-generated comments here. These don't do us any good. If this information is necessary (and I think it is, I would have no idea what this is for), we should have this documented in each externally-facing API we provide (e.g. in pluginmanager.cpp) so that it shows up in user-facing documentation.
| } | ||
|
|
||
|
|
||
| bool Extension::InstallForMigration(std::string versionID) |
Contributor
There was a problem hiding this comment.
This seems fine, but where are the Python and Rust equivalents? Also, see other note about moving documentation to here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API fix for deprecated plugins being impossible to uninstall from UI. Fixes #8545