BinaryNinjaDebugger::Socket::Kill

[sentry]

Sentry Issue: BINARYNINJA-PV

EXCEPTION_ACCESS_VIOLATION_READ / 0x0: Fatal Error: EXCEPTION_ACCESS_VIOLATION_READ / 0x0
  File "socket.h", line 105, in BinaryNinjaDebugger::Socket::Kill
  File "corelliumadapter.cpp", line 315, in BinaryNinjaDebugger::CorelliumAdapter::Quit
  File "mutex.cpp", line 159, in _Mtx_unlock
  File "mutex", line 66, in std::_Mutex_base::unlock
  File "mutex", line 433, in std::lock_guard<T>::{dtor}
...
(21 additional frame(s) were not displayed)

[plafosse]

BINARYNINJA-PV: Corellium quit before socket creation

Sentry issue: https://vector35.sentry.io/issues/7712989514/

Representative events:

• be14b47fdc6a40a7bad50f16e55f031b
• ff9407317a124e9cd4e303006bcb613f

Finding

Both Windows Free stable events on binaryninja@6.0.10601 fault in
Socket::Kill after CorelliumAdapter::Quit calls it with a null this
pointer. CorelliumAdapter::m_socket has no initializer and is assigned only
after Connect starts. Quit, Detach, and the target-exit handler all used
it unconditionally.

The controller trace shows a stop/quit request overlapping the debugger worker
path before the Corellium connection has produced a socket. This is the same
root cause previously observed as BINARYNINJA-QF.

Reproduction

In a debugger test harness, construct a CorelliumAdapter for a valid test
BinaryView but do not call Connect. Invoke Quit (or Detach) immediately.
For deterministic pre-fix behavior, make the test seam set m_socket to null
before invoking the lifecycle operation. The old code calls Socket::Kill
through that null pointer; the patched code completes the failed shutdown
without dereferencing it.

The Sentry events also identify the customer workflow: start a Corellium debug
session and stop it while connection setup has not completed. The exact remote
endpoint is not present in the event and is not needed to exercise the local
lifecycle bug.

Reproduction status: source-level deterministic; not run in this worktree
because no debugger test build is configured.

Suggested patch

Value-initialize m_socket and guard every lifecycle Kill call. This preserves
connected-session behavior and makes shutdown safe before or after a failed
connection.

Patch confidence: high.