fix: harden verifyCode with strict length and digit validation - #13
Merged
Merged
Conversation
francislavoie
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
This PR hardens
GoogleAuthenticator::verifyCode()by adding strict length checking and digit-only validation. Invalid inputs are now rejected before entering the time-window comparison loop, eliminating potential timing attack surfaces and preventing malformed codes from reachinghash_equals.🔧 Key Changes
1.
src/GoogleAuthenticator.php— Input Validation GuardAdded a pre-check at the beginning of
verifyCode()(lines 147–149):_codeLength(default 6, configurable 6–8).\n).hash_equalsentirely.Security Benefits:
hash_equals, mitigating timing side-channel risks.abcdef,12345\n, zero-padded 7-digit strings).2.
tests/GoogleAuthenticatorTest.php— 3 New Security Test CasestestVerifyCodeWithLeadingZero()0+ valid 6-digit code) is rejectedtestVerifyCodeWithEightDigits()testVerifyCodeRejectsNonNumericCode()All existing tests continue to pass with no regressions.
📁 Scope of Impact
src/GoogleAuthenticator.phpverifyCode()tests/GoogleAuthenticatorTest.php