revert ubuntu based images back to single stage#523
Merged
Merged
Conversation
tjwatson
reviewed
Jul 21, 2023
tjwatson
reviewed
Jul 21, 2023
| FROM websphere-liberty:23.0.0.6-kernel-java8-ibmjava AS installBundle | ||
| FROM websphere-liberty:kernel-java8-ibmjava | ||
|
|
||
| USER root |
Member
There was a problem hiding this comment.
How did this work before without USER root?
Contributor
Author
There was a problem hiding this comment.
I think that's a question for @leochr, and whether we need it for all the full images, including java8
Member
There was a problem hiding this comment.
USER root shouldn't be used, especially with single-stage Dockerfile as that'll switch the default user of Liberty full image. I believe it was added as part of multi-stage Dockerfiles changes, but I don't think it's needed to perform the operations in the full image.
Contributor
Author
|
@leochr udpated |
wraschke
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert ubuntu based images back to single stage as requested by docker team for the official builds