update.sh script invoked by main branch workflow needs to be in vNext#558
Merged
Conversation
wraschke
force-pushed
the
update-script-needed-vNext
branch
from
623c601 to
5e15041
Compare
leochr
reviewed
Oct 31, 2023
| @@ -0,0 +1,72 @@ | |||
| #!/bin/bash | |||
|
|
|||
| echo "Hello from the update.sh script!" | |||
Member
There was a problem hiding this comment.
I'll suggest adding this script under a folder: internal or ci
Suggestion for file name: "create-new-release.sh"
Member
Author
There was a problem hiding this comment.
@leochr, I renamed the file and placed in the "internal" directory. Please take another look.
wraschke
force-pushed
the
update-script-needed-vNext
branch
from
697a114 to
69f8047
Compare
leochr
previously approved these changes
Oct 31, 2023
leochr
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update.sh script is invoked by the workflow file being introduced under #557. That workflow checks out the vNext branch, so the script must be present there. Otherwise, a failure like this will occur in workflow: