Skip to content

Updates for the release of 24.0.0.3#594

Closed
github-actions[bot] wants to merge 2 commits into
vNextfrom
24.0.0.3-release
Closed

Updates for the release of 24.0.0.3#594
github-actions[bot] wants to merge 2 commits into
vNextfrom
24.0.0.3-release

Conversation

@github-actions

@github-actions github-actions Bot commented Mar 1, 2024

Copy link
Copy Markdown
Contributor

Created by Github Actions

@github-actions github-actions Bot requested review from leochr and mbroz2 March 1, 2024 12:38
@CLAassistant

CLAassistant commented Mar 1, 2024

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ wraschke
❌ github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@leochr leochr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkertasef @wraschke Thanks for the PR. Added some comments.

ARG LIBERTY_VERSION=24.0.0.3
ARG LIBERTY_URL
ARG DOWNLOAD_OPTIONS=""
ARG LIBERTY_SHA=bd9c64cbf086f03e81ee50e4a44acc6f05af191a

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SHA value must be replaced with placeholder. Same for other Dockerfiles in latest

Comment thread .travis.yml
@@ -10,7 +10,7 @@ before_install:
env:
- RELEASE=../ga/23.0.0.9

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 23.0.0.9 directory must be removed. We only support the last 2 quarterly releases (24.0.0.3 and 23.0.0.12)

@wraschke

wraschke commented Mar 6, 2024

Copy link
Copy Markdown
Member

The create-new-release.sh script with changes to update the LIBERTY_SHA argument was merged under #589. The timestamp of that merge per GitHub interface is March 1, 1:40 PM CST, and this PR was created by the GitHub Actions workflow on March 1, 6:38 AM CST.

So I'm going to close this PR and delete the branch, then re-run the workflow.

@wraschke wraschke closed this Mar 6, 2024
@wraschke wraschke deleted the 24.0.0.3-release branch March 6, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants