Skip to content

Default placeholder for versions fields can be confusing #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wraschke merged 2 commits into from
Mar 1, 2024
Merged

Default placeholder for versions fields can be confusing #595

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
735b7b3
Default placeholder for versions fields can be confusing
wraschke Mar 1, 2024
4c3bb55
Remove Michal as reviewer
wraschke Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/update_files_for_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,11 @@ on:
workflow_dispatch:
inputs:
OLD_VERSION:
description: 'Enter old version'
# Show defaults as examples so user enters correct format.
default: '23.0.0.11'
description: 'Enter old version (what was just released)'
required: true
type: string
NEW_VERSION:
description: 'Enter new version'
default: '23.0.0.12'
description: 'Enter new version (pre-eGA release)'
required: true
type: string
BUILD_LABEL:
Expand Down Expand Up @@ -55,7 +52,7 @@ jobs:

- name: Create Pull Request
run: |
gh pr create -B vNext -H "${{ inputs.NEW_VERSION }}-release" -r mbroz2 -r leochr --title "Updates for the release of ${{ inputs.NEW_VERSION }}" --body "Created by Github Actions"
gh pr create -B vNext -H "${{ inputs.NEW_VERSION }}-release" -r leochr --title "Updates for the release of ${{ inputs.NEW_VERSION }}" --body "Created by Github Actions"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down