Updates for the release 25.0.0.1#658
Merged
Merged
Conversation
leochr
reviewed
Jan 14, 2025
leochr
left a comment
leochr
left a comment
Member
There was a problem hiding this comment.
@gkertasef Thank you for the PR. Added couple of comments
| ARG LIBERTY_URL | ||
| ARG DOWNLOAD_OPTIONS="" | ||
| ARG LIBERTY_SHA=2e27858abf32abb6b6b61caf3a78fafe15472fb4 | ||
| ARG LIBERTY_SHA={replace_with_correct_sha} |
Member
There was a problem hiding this comment.
Can the placeholder be replaced with actual SHA value (similar to the other Dockerfiles)?
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| ARG PARENT_IMAGE=icr.io/appcafe/websphere-liberty:kernel-java8-ibmjava-ubi |
Member
There was a problem hiding this comment.
The tags of the base image for all the 'full' images in 25.0.0.1 folder should include the prefix 25.0.0.1-
leochr
reviewed
Jan 14, 2025
leochr
left a comment
leochr
left a comment
Member
There was a problem hiding this comment.
@gkertasef Thanks for the update. UBI Dockerfiles look fine. The Ubuntu equivalent need similar updates.
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| FROM websphere-liberty:kernel-java8-ibmjava |
Member
There was a problem hiding this comment.
Dockerfiles for the 25.0.0.1 full images on 'Ubuntu' also require the tag prefix 25.0.0.1-
leochr
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.